Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds source and source type for better usage monitoring #43

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

adriangomez24
Copy link
Contributor

What changed? Why?

This PR does the following:

  1. Adds source and source_version to the Cdp and CdpApiClient to be able to differentiate between pure sdk usage and Agentkit extensions.
  2. Tracks this information in string returned by the _get_correlation_data method for CdpApiClient by adding source=sdk and source_version=__version__
  3. Adds a unit test for the above method.

Qualified Impact

If there was an error, _get_correlation_data would not work, but this method is tested. To fix the error, we should rollback.

@cb-heimdall
Copy link

cb-heimdall commented Nov 7, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cdp/constants.py Outdated Show resolved Hide resolved
cdp/constants.py Outdated Show resolved Hide resolved
@John-peterson-coinbase John-peterson-coinbase merged commit 06e33d5 into coinbase:master Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants